Skip to content

Conversation

@jipiboily
Copy link
Contributor

There is a small error in the introduction guide.

The books.show template path is wrong; it doesn't reflect the overall tutorial and makes subsequent steps fail (as the ERB templates are in templates, not views).

@parndt
Copy link

parndt commented Oct 19, 2025

@jipiboily I think this is accurate as-is as it's referring to the path for the ruby view file (not the erb template file). Have I misunderstood?

@jipiboily
Copy link
Contributor Author

@parndt I honestly don't remember clearly. It was when I followed the tutorial, and it failed at that step with the instructions as-is, and it worked with my fixed version, IIRC.

@parndt parndt requested a review from timriley October 25, 2025 08:11
@timriley timriley merged commit 1fc4c4e into hanami:main Nov 7, 2025
4 checks passed
@timriley
Copy link
Member

timriley commented Nov 7, 2025

Thanks @jipiboily!

@jipiboily jipiboily deleted the patch-1 branch November 7, 2025 03:04
timriley added a commit that referenced this pull request Nov 7, 2025
@timriley
Copy link
Member

timriley commented Nov 7, 2025

Actually, I clicked too soon. The path here was correct in the first place, have reverted back in the main branch. If you come across any other issues, though, please keep letting us know :)

@jipiboily
Copy link
Contributor Author

I'm sorry about that guys! I don't recall the details but I guess I was wrong back then. Sorry for the trouble.

@parndt
Copy link

parndt commented Nov 7, 2025

I'm sorry about that guys! I don't recall the details but I guess I was wrong back then. Sorry for the trouble.

no worries JP 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants